Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISACQCOMP-171 Implement "Find location" components #737

Merged
merged 21 commits into from
Dec 16, 2023

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Dec 6, 2023

Purpose

https://issues.folio.org/browse/UISACQCOMP-171

Approach

  • Implement new lookup based on FindRecord component;
  • Implement event emitter mechanism to communicate by events;
  • Extend existing tools to support new functionality (initial selected records);
  • Implement utils to process fetch data on UI side (required to filter by "assigned" status);
  • Add unit tests;

Screenshot

chrome_2gIfAeoEff.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Dec 6, 2023
Copy link

github-actions bot commented Dec 6, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit fab38d9. ± Comparison against base commit b727ab5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Jest Unit Test Statistics

    1 files  ±  0  165 suites  +9   4m 22s ⏱️ +12s
429 tests +18  428 ✔️ +18  1 💤 ±0  0 ±0 
432 runs  +18  431 ✔️ +18  1 💤 ±0  0 ±0 

Results for commit fab38d9. ± Comparison against base commit b727ab5.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam marked this pull request as ready for review December 14, 2023 19:22
@usavkov-epam usavkov-epam requested review from a team December 14, 2023 19:24
lib/FindLocation/FindLocationLookup.js Outdated Show resolved Hide resolved
lib/FindLocation/FindLocationLookup.js Outdated Show resolved Hide resolved
lib/utils/EventEmitter/EventEmitter.js Show resolved Hide resolved
Copy link

@usavkov-epam usavkov-epam merged commit ca6baf5 into master Dec 16, 2023
6 checks passed
@usavkov-epam usavkov-epam deleted the UISACQCOMP-171 branch December 16, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants